cyplo/deescalate
Watch
1
0
Fork
You've already forked deescalate
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Run CI on pull requests as well as main #3

Merged
cyplo merged 2 commits from ai-agent/ci-on-pull-requests into main 2026-11-08 21:53:19 +00:00 AGit
Conversation 0 Commits 2 Files changed 4 +89 -55
ai-agent commented 2026-11-08 21:47:27 +00:00
Collaborator

Agents can only open pull requests through AGit, which never fires push, so CI never saw their changes before merge; #1 and #2 have no runs at all.

CI now runs on every pull request and on main, on the host runner like ha-power-manager: clippy with warnings as errors, the test suite, statix, nix flake check, and a full build of the package.

Adding that build showed nix build was broken on main: naersk's own cargo 1.87 rejects the let-chains the code uses. naersk now follows the flake's nixpkgs, whose pin is unchanged.

This PR's own run uses main's old push-only workflow, so the first real run is on merge. I validated the file with forgejo-runner validate and ran each job's commands locally.

Agents can only open pull requests through AGit, which never fires `push`, so CI never saw their changes before merge; #1 and #2 have no runs at all. CI now runs on every pull request and on main, on the host runner like ha-power-manager: clippy with warnings as errors, the test suite, statix, `nix flake check`, and a full build of the package. Adding that build showed `nix build` was broken on main: naersk's own cargo 1.87 rejects the let-chains the code uses. naersk now follows the flake's nixpkgs, whose pin is unchanged. This PR's own run uses main's old push-only workflow, so the first real run is on merge. I validated the file with `forgejo-runner validate` and ran each job's commands locally.
nix build and nix run failed: naersk used its own nixpkgs pin, with
cargo 1.87, which rejects the let-chains the code uses (stable since
1.88). The dev shell already had 1.91, so cargo builds never showed it.
naersk now follows the flake's nixpkgs; that pin itself is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Run CI on pull requests as well as main
All checks were successful
CI / Nix checks and package build (pull_request) Successful in 2m19s
Details
CI / Lint (pull_request) Successful in 2m57s
Details
CI / Run tests (pull_request) Successful in 4m18s
Details
CI / Nix checks and package build (push) Successful in 21s
Details
CI / Lint (push) Successful in 24s
Details
CI / Run tests (push) Successful in 48s
Details
bc25bb4d71 
The workflow ran only on push, and agents can only open pull requests
through AGit, which never fires push, so their changes went untested
until merged. CI now runs on pull requests and on main: clippy with
warnings as errors, the test suite, statix, nix flake check and a full
nix build of the package, on the host runner like the other Rust repos.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cyplo merged commit bc25bb4d71 into main 2026-11-08 21:53:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cyplo/deescalate!3
No description provided.